Skip to content

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pretty548 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls #1097

Pretty548 wants to merge 6 commits into from

Conversation

@Pretty548
Copy link

@Pretty548 Pretty548 commented Jan 30, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. Created a form to collect customer name, email, t-shirt colour, and size
  2. Added validation to ensure all fields are required
  3. Implemented name validation with defined input rules
  4. Validated email input using a standard email pattern
  5. Provided exactly three colour options and restricted selection to those options
  6. Ensured the form has no action attribute as required

Questions

How did you decide what makes a “valid” customer name, and what rules did you use to validate it?

@netlify
Copy link

netlify bot commented Jan 30, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1bab41c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6980f6b1b0fa5200080f49fc
😎 Deploy Preview https://deploy-preview-1097--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
6 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@Pretty548 Pretty548 mentioned this pull request Jan 30, 2026
Open
@Pretty548 Pretty548 changed the title Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Form Controls Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls Jan 30, 2026
@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
cjyuan
cjyuan reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Regarding your question:

How did you decide what makes a “valid” customer name, and what rules did you use to validate it?

I would probably reference the answers gathered from AI and Google search.
If there is a rule, then chances are we can use JavaScript to enforce the rule.

Form-Controls/index.html Outdated
Comment on lines 42 to 48
<input
type="radio"
id="color-blue"
name="color"
value="blue"
/>
<label for="color-blue">Blue</label>
Copy link
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
We can also wrap the radio button inside the label element as:

<label><input type="radio" name="color" value="blue"> Blue</label>

This way, we don't have to introduce id and for attributes.

Copy link
Author

@Pretty548 Pretty548 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Cjyuan for your suggestion. I have wrapped the radio buttons as per your suggestion and i hope i did it right

Form-Controls/index.html Outdated
required
/><br><br>
<fieldset>
<legend>Choose a T-shirt Colour:</legend>
Copy link
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wordings used on lines 32 and 58 could be made more consistent.

May I suggest showing your code to an AI tool and ask it to check for consistency and possible improvements?
It can often help us catch errors, improve consistency, and reinforce best practices.

Copy link
Author

@Pretty548 Pretty548 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for pointing out that. i have checked and improved , i hope now its better.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pretty548 @cjyuan @Luke-Manyamazi